Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove macos-11; update Lima etc. #47

Merged
merged 4 commits into from
Sep 18, 2024
Merged

CI: remove macos-11; update Lima etc. #47

merged 4 commits into from
Sep 18, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda added this to the v1.1.5 milestone Sep 17, 2024
jandubois
jandubois previously approved these changes Sep 17, 2024
View reviewed changes
@AkihiroSuda AkihiroSuda changed the title CI: remove macos-11 CI: remove macos-11; update Lima etc. Sep 17, 2024
jandubois
jandubois previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@AkihiroSuda
Copy link
Member Author

macos-13 CI can't be green

@jandubois
Copy link
Member

macos-13 CI can't be green

Is this related to moving from macos-13-xl to macos-13? Any reason not to stay on macos-13-xl?

@AkihiroSuda
CI: use checkout@v4
557d9b9 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
CI: use setup-go@v5
4c292e2 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
CI: use Lima v0.23.2
dc04de2 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Sep 18, 2024 •
edited
Loading

Reverted to macos-13-xl. Seems still (relatively?) stable.

@jandubois
Copy link
Member

Yeah, but now macos-12 seems to be hanging. 😞

@AkihiroSuda
Copy link
Member Author

I also wonder whether macos-13-xl is still safe to use.
Apparently no longer documented in https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners ?

@jandubois
Copy link
Member

Apparently no longer documented in https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners ?

I think it is to avoid confusion with the macos-13-xlarge runner using M1 and macos-13-large using Intel.

I suspect that macos-13-xl is just a now undocumented alias for macos-13-large.

You can see the names on https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners

@AkihiroSuda
Copy link
Member Author

I suspect that macos-13-xl is just a now undocumented alias for macos-13-large.

I came to the same conclusion. Really confusing.. 😅

@jandubois
Copy link
Member

I suspect that macos-13-xl is just a now undocumented alias for macos-13-large.

It is not explicitly called out, but kind of implied by

The 12-core macOS larger runner is moving from xlarge to large, and is still available by updating the runs-on: key to macos-latest-large, macos-12-large, or macos-13-large.

(from https://github.blog/news-insights/product-news/introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/)

@jandubois
Copy link
Member

I came to the same conclusion. Really confusing.. 😅

We should probably switch to the documented macos-13-large name to reduce confusion…

@AkihiroSuda
CI: remove macos-11; rename macos-13-xl to macos-13-large
806a750 
- macos-11 is no longer available
  https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

- macos-13-xl was silently renamed to macos-13-large at some point

Signed-off-by: Akihiro Suda <[email protected]>
jandubois
jandubois approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 26c56cb into lima-vm:master Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@AkihiroSuda @jandubois